D2/S5/S8 mod - move active loop by 1 beat

JuanT · Jan 21, 2019

Nick Moon said: ↑

Now Pioneer have essentially caught up NI don't stand a chance as their reputation stinks. Our controllers had so much potential, but I'm pleased I've been able to make mine work as I want.
Click to expand...

Couldn't agree more... (sigh)
And thank you guys you made at least these awesome mods!

Nick Moon said: ↑

Unfortunately my mods will not run on an S5... I actually started with an S5 but when it was stolen I replaced it with an S8 and also picked up a bargain second hand D2 on the way. Lack of buttons and knobs aside, everything I've done could be made to work on the S5, and I've assisted S5 user Jike whose S5 mods are really neat, and hopefully there will be more of that happening
Click to expand...

Geez... That's too bad your mod won't run on an S5. Although maybe I can also try helping to port it somehow (my programming experience is limited, but with your support/assistance as you did with Jike could maybe work again : )

Anyways, as said, I also have access to an S8 from a close friend. So my offering to test it out and help making a user manual stands still

Nick Moon · Jan 22, 2019

JuanT said: ↑

Couldn't agree more... (sigh)
And thank you guys you made at least these awesome mods!

Geez... That's too bad your mod won't run on an S5. Although maybe I can also try helping to port it somehow (my programming experience is limited, but with your support/assistance as you did with Jike could maybe work again : )

Anyways, as said, I also have access to an S8 from a close friend. So my offering to test it out and help making a user manual stands still
Click to expand...

So my latest delay... I realised I hadn't tested my TP 3 release on Windows at all... Doesn't work at present so if I release a beta would only be for macOS until I can resolve - I see you are on Windows

Hopefully won't take forever to resolve, but don't have much spare time at the moment!

JuanT · Jan 22, 2019

Nick Moon said: ↑

So my latest delay... I realised I hadn't tested my TP 3 release on Windows at all... Doesn't work at present so if I release a beta would only be for macOS until I can resolve - I see you are on Windows

Hopefully won't take forever to resolve, but don't have much spare time at the moment!
Click to expand...

Oh, well. I have a Mac also!
Nah, just kiddin (lol)

Now, seriously, no issues, Nick. Don't mean to stress you or anythin (it seems like you're already pushing yourself quite much investing your little spare time after work and really trying to achieve a really neat and very handy mod).

When ever it's ready, it will be ready! We'll patiently wait for it, and, from my end, happy to help testing it out anytime

Disco Danny · May 24, 2020

Nick Moon said: ↑

I think this should be ok on the S5 - works ok on my D2. No changes to the Wire {} code required...

Code:

  // Properties/function to facilitate via SHIFT LOOP encoder a
  // "1 beat move" alternative to replace the NI provided "loop size move"
  // for where loop is active. Where loop is not active a "8 beat jump" will
  // replace the NI provided "loop size beatjump"
  // function includes details of the beat size values so can be changed easily
  AppProperty { id: deckALoopEnabled; path: "app.traktor.decks.1.loop.active" }
  AppProperty { id: deckAMoveMode; path: "app.traktor.decks.1.move.mode" }
  AppProperty { id: deckAMoveSize; path: "app.traktor.decks.1.move.size" }
  AppProperty { id: deckAMove; path: "app.traktor.decks.1.move" }
  AppProperty { id: deckBLoopEnabled; path: "app.traktor.decks.2.loop.active" }
  AppProperty { id: deckBMoveMode; path: "app.traktor.decks.2.move.mode" }
  AppProperty { id: deckBMoveSize; path: "app.traktor.decks.2.move.size" }
  AppProperty { id: deckBMove; path: "app.traktor.decks.2.move" }
  AppProperty { id: deckCLoopEnabled; path: "app.traktor.decks.3.loop.active" }
  AppProperty { id: deckCMoveMode; path: "app.traktor.decks.3.move.mode" }
  AppProperty { id: deckCMoveSize; path: "app.traktor.decks.3.move.size" }
  AppProperty { id: deckCMove; path: "app.traktor.decks.3.move" }
  AppProperty { id: deckDLoopEnabled; path: "app.traktor.decks.4.loop.active" }
  AppProperty { id: deckDMoveMode; path: "app.traktor.decks.4.move.mode" }
  AppProperty { id: deckDMoveSize; path: "app.traktor.decks.4.move.size" }
  AppProperty { id: deckDMove; path: "app.traktor.decks.4.move" }
  //
  function customLoopMove(_deckId, _direction) {
    //
    // Mode values - 2[Beatjump] 1[Loop]
    // Size values - 0[ultrafine] 1[1/32 beat] 2[1/16 beat] 3[1/8 beat] 4[1/4 beat] 5[1/2 beat] 6[1 beat]
    //               7[2 beats] 8[4 beats] 9[8 beats] 10[16 beats] 11[32 beats] 12[loop size]
    //
    if (_deckId == 1) {
      deckAMoveMode.value = (deckALoopEnabled.value ? 1 : 0);   // 1 for loop move; 0 for beatjump
      deckAMoveSize.value = (deckALoopEnabled.value ? 6 : 9);   // default values of 1 beat for loopmove; 8 beats for beatjump
      deckAMove.value = _direction;                             // -1 = back +1 = forward
    }
    if (_deckId == 2) {
      deckBMoveMode.value = (deckBLoopEnabled.value ? 1 : 0);   // 1 for loop move; 0 for beatjump
      deckBMoveSize.value = (deckBLoopEnabled.value ? 6 : 9);   // default values of 1 beat for loopmove; 8 beats for beatjump
      deckBMove.value = _direction;                             // -1 = back +1 = forward
    }
    if (_deckId == 3) {
      deckCMoveMode.value = (deckCLoopEnabled.value ? 1 : 0);   // 1 for loop move; 0 for beatjump
      deckCMoveSize.value = (deckCLoopEnabled.value ? 6 : 9);   // default values of 1 beat for loopmove; 8 beats for beatjump
      deckCMove.value = _direction;                             // -1 = back +1 = forward
    }
    if (_deckId == 4) {
      deckDMoveMode.value = (deckDLoopEnabled.value ? 1 : 0);   // 1 for loop move; 0 for beatjump
      deckDMoveSize.value = (deckDLoopEnabled.value ? 6 : 9);   // default values of 1 beat for loopmove; 8 beats for beatjump
      deckDMove.value = _direction;                             // -1 = back +1 = forward
    }
  }

Click to expand...

Hi Nick,

This mod works like a charm and is a very welcome addition.
But the moment when I touch the LOOP encoder, the 4 midi buttons get inactive on my D2's.
The only why to activate them again is via the preferences menu and then double click the 'Enable MIDI controls' option.
But everytime I touch the LOOP encoder after that, the 4 midi buttons get inactive again.
I tried to solve this problem but without any luck so far.

Maybe you got any idea to solve this?

I use the 4 MIDI push buttons to control an external FX device via midi connection.

Nick Moon · May 27, 2020

Disco Danny said: ↑

Hi Nick,

This mod works like a charm and is a very welcome addition.
But the moment when I touch the LOOP encoder, the 4 midi buttons get inactive on my D2's.
The only why to activate them again is via the preferences menu and then double click the 'Enable MIDI controls' option.
But everytime I touch the LOOP encoder after that, the 4 midi buttons get inactive again.
I tried to solve this problem but without any luck so far.

Maybe you got any idea to solve this?

I use the 4 MIDI push buttons to control an external FX device via midi connection.
Click to expand...

Hi after another long break I'm starting to look at things again, I'll try and get back to you on this before the end of the week. You may be the first person I know who has used the MIDI buttons as NI intended!

Aleix Jiménez · May 28, 2020

Nick Moon said: ↑

Hi after another long break I'm starting to look at things again, I'll try and get back to you on this before the end of the week. You may be the first person I know who has used the MIDI buttons as NI intended!
Click to expand...

Nice to see you back in the game Nick Moon

Disco Danny · May 28, 2020

Nick Moon said: ↑

Hi after another long break I'm starting to look at things again, I'll try and get back to you on this before the end of the week. You may be the first person I know who has used the MIDI buttons as NI intended!
Click to expand...

Hi Nick.

Meanwhile I found out that when the 4 midi buttons are inactive they get active again by pressing one of the small arrow buttons situated on the left and right bottom next to the screens. This is kind of an acceptable workaround for me.

And yes, that 4 midi buttons and faders work great to remote control my TC electronic One XL via midi, and still use all the 'normal' Traktor functions of the controller at the same time ( so not in midi mode when the screens are switched off and basically the controller gets useless)

Nick Moon · May 31, 2020

Disco Danny said: ↑

Hi Nick.

Meanwhile I found out that when the 4 midi buttons are inactive they get active again by pressing one of the small arrow buttons situated on the left and right bottom next to the screens. This is kind of an acceptable workaround for me.

And yes, that 4 midi buttons and faders work great to remote control my TC electronic One XL via midi, and still use all the 'normal' Traktor functions of the controller at the same time ( so not in midi mode when the screens are switched off and basically the controller gets useless)
Click to expand...

So where I have borrowed the MIDI controls to implement new functions, those functions will only work when the performance mode selected is MIDI - the other modes - FILTER, PITCH & FX SEND - utilise the (MIDI) controls and therefore need them dedicated for other functions. I will make some checks around the changes I'm made to the transport controls to see whether the impact anything they should not. The LOOP encoder was an early mod, before I know all I know now.

Are you using my whole mod package, or have you taken code from it, as required, and implemented into your own mod? The answer to that is significant, in pointing me in the right direction

Thanks
Nick

Disco Danny · Jun 1, 2020

Nick Moon said: ↑

I think this should be ok on the S5 - works ok on my D2. No changes to the Wire {} code required...

Code:

  // Properties/function to facilitate via SHIFT LOOP encoder a
  // "1 beat move" alternative to replace the NI provided "loop size move"
  // for where loop is active. Where loop is not active a "8 beat jump" will
  // replace the NI provided "loop size beatjump"
  // function includes details of the beat size values so can be changed easily
  AppProperty { id: deckALoopEnabled; path: "app.traktor.decks.1.loop.active" }
  AppProperty { id: deckAMoveMode; path: "app.traktor.decks.1.move.mode" }
  AppProperty { id: deckAMoveSize; path: "app.traktor.decks.1.move.size" }
  AppProperty { id: deckAMove; path: "app.traktor.decks.1.move" }
  AppProperty { id: deckBLoopEnabled; path: "app.traktor.decks.2.loop.active" }
  AppProperty { id: deckBMoveMode; path: "app.traktor.decks.2.move.mode" }
  AppProperty { id: deckBMoveSize; path: "app.traktor.decks.2.move.size" }
  AppProperty { id: deckBMove; path: "app.traktor.decks.2.move" }
  AppProperty { id: deckCLoopEnabled; path: "app.traktor.decks.3.loop.active" }
  AppProperty { id: deckCMoveMode; path: "app.traktor.decks.3.move.mode" }
  AppProperty { id: deckCMoveSize; path: "app.traktor.decks.3.move.size" }
  AppProperty { id: deckCMove; path: "app.traktor.decks.3.move" }
  AppProperty { id: deckDLoopEnabled; path: "app.traktor.decks.4.loop.active" }
  AppProperty { id: deckDMoveMode; path: "app.traktor.decks.4.move.mode" }
  AppProperty { id: deckDMoveSize; path: "app.traktor.decks.4.move.size" }
  AppProperty { id: deckDMove; path: "app.traktor.decks.4.move" }
  //
  function customLoopMove(_deckId, _direction) {
    //
    // Mode values - 2[Beatjump] 1[Loop]
    // Size values - 0[ultrafine] 1[1/32 beat] 2[1/16 beat] 3[1/8 beat] 4[1/4 beat] 5[1/2 beat] 6[1 beat]
    //               7[2 beats] 8[4 beats] 9[8 beats] 10[16 beats] 11[32 beats] 12[loop size]
    //
    if (_deckId == 1) {
      deckAMoveMode.value = (deckALoopEnabled.value ? 1 : 0);   // 1 for loop move; 0 for beatjump
      deckAMoveSize.value = (deckALoopEnabled.value ? 6 : 9);   // default values of 1 beat for loopmove; 8 beats for beatjump
      deckAMove.value = _direction;                             // -1 = back +1 = forward
    }
    if (_deckId == 2) {
      deckBMoveMode.value = (deckBLoopEnabled.value ? 1 : 0);   // 1 for loop move; 0 for beatjump
      deckBMoveSize.value = (deckBLoopEnabled.value ? 6 : 9);   // default values of 1 beat for loopmove; 8 beats for beatjump
      deckBMove.value = _direction;                             // -1 = back +1 = forward
    }
    if (_deckId == 3) {
      deckCMoveMode.value = (deckCLoopEnabled.value ? 1 : 0);   // 1 for loop move; 0 for beatjump
      deckCMoveSize.value = (deckCLoopEnabled.value ? 6 : 9);   // default values of 1 beat for loopmove; 8 beats for beatjump
      deckCMove.value = _direction;                             // -1 = back +1 = forward
    }
    if (_deckId == 4) {
      deckDMoveMode.value = (deckDLoopEnabled.value ? 1 : 0);   // 1 for loop move; 0 for beatjump
      deckDMoveSize.value = (deckDLoopEnabled.value ? 6 : 9);   // default values of 1 beat for loopmove; 8 beats for beatjump
      deckDMove.value = _direction;                             // -1 = back +1 = forward
    }
  }

Click to expand...

Hi Nick.
This is the only part I copied and pasted.
When the midi buttons get inactive the bottom line of the screens show 'filter' instead of 'midi'.
Hope this helps.
Thanks in advance for al the great work.

Disco Danny · Jun 5, 2020

Yes fixed it. ;-)

For the ones who are interested. Just fix this in the DeckS8_Style.qml file.
(See jpg which small ajdustments to make in that file, simply replace the word 'filter' by 'midi')

Nick Moon · Jun 6, 2020

Disco Danny said: ↑

Yes fixed it. ;-)

For the ones who are interested. Just fix this in the DeckS8_Style.qml file.
(See jpg which small ajdustments to make in that file, simply replace the word 'filter' by 'midi')

View attachment 93275 View attachment 93275
Click to expand...

I'd been looking into the issue rather than the code you were referencing and have ended up confused! For my piece of mind in reviewing the issue on my current development release, a few questions:

1) What controller are you using? I assumed D2 or S8 (Deck_S8Style.qml being a hint), but the snippet above looks like S5 code.

2) What version of Traktor are you using? I've gone back and looked at the code for the first release of my mods which was baselined for 2.11.
The code you confirmed on Monday (1/6) you were using is very old code from back in the day when I worked on this specific mod. Having said that, it should work on 2.11 or 3.x, but there were other changes what went with it which were required 4 times, example for Deck A being:
Code:
            Wire { from: "%surface%.encoder.turn"; to: EncoderScriptAdapter { onIncrement: { customLoopMove(1, 1); } onDecrement: { customLoopMove(1, -1); } } enabled: module.shift }
            Wire { from: "%surface%.encoder.push"; to: TogglePropertyAdapter { path: "app.traktor.decks.1.loop.active"; } enabled: module.shift }
Did you implement these?

3) Did you bolt the code from this thread on top of someone else's mods?

4) I can see the how the solution you have arrived at works, but it would not work within my overall mod, which is why I'm still thinking about your use case. The first release of my mods onwards work on the assumption the MIDI controls are used for mod functions or just MIDI.

5) Not sure if your fix would hold up on Stem decks, which may not be an issue for you.

Disco Danny · Nov 2, 2020

Hi Nick Moon
Sorry for my late response.
Things worked great until I updated to TPvversion 3.4

In the meantime fixed the problem by working with the JIKE MOD (and a lot of your work in that MOD as well).
https://maps.djtechtools.com/mappings/8924
That works like a charm on the S5 but not on my D2's unfortunately.

Got a lot of tips from JIKE to try to fix it for the D2's but I can't get it to work.
The thing I found out is that the file that needs to be manipulated for the D2's is the file 'deck_S8style.qml' which is located here:
C:\Program Files\Native Instruments\Traktor Pro 3\Resources64\qml\CSI\Common\Deck_S8Style.qml

But it's to complex for me to get this MOD working on the D2 as well.
So I thought, you as a D2 owner,, and lots of sparetime
Maybe you can fix this?

dj_estrela · Dec 12, 2020

Hi all
I've now found this old thread, and now appreciate even better why all cool user-driven innovation is only on QML. This means NI controllers.

Sadly I like big jogwheels. For me this means the DDJ-1000.
https://github.com/pestrela/dj_kb#why-i-like-big-jogwheels

As such I pushed the MIDI way beyond limits, well into BOME:
https://github.com/pestrela/dj_kb#Why-I-moved-to-BOME-midi-mapping-Impossible-features

This also explains the few traffic I get about CMDR, which I revived with new cool features:
https://www.native-instruments.com/...ller-manager-done-right-new-2020-link.409243/

---------------
I see really impressive work in this 2018 thread, and fast forward to 2020, on the current variety of display mods that already expanded to non-display features.
Well done!

I have my own advanced (generic) features as well:
https://github.com/pestrela/dj_maps...Basic Info 6 - Enabling Advanced features.png

One pertinet topic on this thread is how to add more and mre functionality in a user-friendly way. I faced the same.
One options is whole shift layers:
(page 30 and ff of https://github.com/pestrela/dj_maps/blob/main/akai_amx/AMX TP3_TP2 - Quick overview.pdf )

A better option is Gestures: either Long press and double click:
(slide 71 of https://github.com/pestrela/dj_maps/blob/main/ddj_1000/3 - Documentation/DDJ-1000 - Manual.pdf )

Cheers all

D2/S5/S8 mod - move active loop by 1 beat

JuanT NI Product Owner

Nick Moon NI Product Owner

JuanT NI Product Owner

Disco Danny NI Product Owner

Nick Moon NI Product Owner

Aleix Jiménez Active Member

Disco Danny NI Product Owner

Nick Moon NI Product Owner

Disco Danny NI Product Owner

Disco Danny NI Product Owner

Nick Moon NI Product Owner

Disco Danny NI Product Owner

dj_estrela Well-Known Member

Useful Searches

D2/S5/S8 mod - move active loop by 1 beat

JuanT NI Product Owner

Nick Moon NI Product Owner

JuanT NI Product Owner

Disco Danny NI Product Owner

Nick Moon NI Product Owner

Aleix Jiménez Active Member

Disco Danny NI Product Owner

Nick Moon NI Product Owner

Disco Danny NI Product Owner

Disco Danny NI Product Owner

Nick Moon NI Product Owner

Disco Danny NI Product Owner

dj_estrela Well-Known Member