New Loop size indicator not synchronized with (real) loop length

And here's the 3rd (out of 4) bug I wanted to report!

Bug description
The Traktor UI and properties aren’t updated when Loop size is modified moving the Loop In/Out position. It’s especially noticeable when setting a regular size beat loop like a 4 beat loop, for example, and doubling it so that it becomes an 8 loop. The Traktor UI doesn’t reflect the new loop size and therefore will still display 4 as the loop size.

Steps to reproduce the issue

1. Set a new loop
2. Open the Move Panel in Traktor Pro
3. Set the move mode (app.traktor.decks.X.move.mode) to Loop In or Loop Out
4. Set the move size (app.traktor.decks.X.move.size) to Loop.
5. Use the left / right arrows to move (app.traktor.decks.X.move) the Loop In/Out position.
6. Spot the issue: You have a Loop which is the double/half of the size of the Loop you set, but the UI stills shows the original Loop Size.

Expected behavior
When using these App Properties to modify the loop size, the loop size AppProperty (app.traktor.decks.X.loop.size) should be updated accordingly --> rounded to the most similar size.

Suggested solution
When the value of the AppProperty app.traktor.decks.X.track.cue.active.length is modified (and deck is in an active loop), update the loop size property rounding the loop length to the most similar value.

 

I see what's the problem there however I wonder if this won't introduce even more confusion in case of unusual loops as 6 bars loops.
What would be the closest similar value in that case for example ?

In my opinion, in most of the cases, the "shown loop length" and the "actual loop length" would not be synchronised and I think that's why we've decided to not edit this value at all.

If this becomes a more requested fix, we may consider thinking about a solution though.

 

Yeah, that's the only tricky situation... However, I believe benefits > this problem. Aside from this, the situation I described earlier causes that, for example:
-Started with an 8 beat loop
-Reduced it to 4 beats
-Reduced it again to 2 beats

Now you have the UI indicating an 8 beat loop while in the Waveform there's clearly a 2 beat loop. Furthermore, if you press the 8 beat loop button now, to revert from a 2 beats loop to the original 8 beats loop, the Loop will deactivate (this buttons toggle the loop active state if, when pressed, the loop was already of that button's size).
Check the image below (2 beats on the waveform, 8 beats on the loop size bar):


A smart way to partially solve the problem you suggest a fix to this could introduce would be that, when doubling/halving:

1. Check if the loop size is exactly (or very close) to any of the predefined loop sizes.
1.1. Read the current loop length in samples
1.2. Read the track's bitrate (and bpm?) of the track
1.3. Use track properties to convert X beats to samples to properly compare loop size with loop length
1.4. Compare (available [0.125, 0.25, 0.5, 1, 2, 4, 8, 16, 32]) loop sizes with loop length (with a margin of error for "manual loop")

2. If step 1.4 has a match:
2.1. The loop half / double will properly be displayed on the UI, because we made sure of it on 1.4 --> update the app.traktor.decks.X.loop.size property
3. If step 1.4 DOESN'T have a match:
3.1. Continue with current behaviour?

 

You could just not highlight ANY of them when the loop does not match any. No need to highlight the wrong one imo

 

That would be an option. What it’s not an option, in my opinion, is that it stays as it is right now —> it feels/is “broken

 

A ticket has been filled as TP-13913.